Skip to content

A small typo in a doc (imageProcessingDispatcher -> jsonProcessingDispatcher) #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ultraon opened this issue Dec 23, 2021 · 1 comment
Closed
Labels
docs KDoc and API reference

Comments

@ultraon
Copy link

ultraon commented Dec 23, 2021

Hello, looks like a small typo in CoroutineDispatcher.kt

* private val imageProcessingDispatcher = backgroundDispatcher.limitedParallelism(3)

Need to change from imageProcessingDispatcher to jsonProcessingDispatcher, so it will look like:

     * private val backgroundDispatcher = newFixedThreadPoolContext(4, "App Background")
     * // At most 2 threads will be processing images as it is really slow and CPU-intensive
     * private val imageProcessingDispatcher = backgroundDispatcher.limitedParallelism(2)
     * // At most 3 threads will be processing JSON to avoid image processing starvation
     * private val jsonProcessingDispatcher = backgroundDispatcher.limitedParallelism(3)
     * // At most 1 thread will be doing IO
     * private val fileWriterDispatcher = backgroundDispatcher.limitedParallelism(1)
@qwwdfsad
Copy link
Collaborator

Hi, thanks for noticing! Fixed in develop

qwwdfsad added a commit that referenced this issue Jan 24, 2022
@qwwdfsad qwwdfsad added the docs KDoc and API reference label Jan 24, 2022
yorickhenning pushed a commit to yorickhenning/kotlinx.coroutines that referenced this issue Jan 28, 2022
dee-tree pushed a commit to dee-tree/kotlinx.coroutines that referenced this issue Jul 21, 2022
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this issue Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs KDoc and API reference
Projects
None yet
Development

No branches or pull requests

2 participants