Skip to content

unnecceserry join #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohamadk opened this issue Aug 25, 2021 · 2 comments
Closed

unnecceserry join #2896

mohamadk opened this issue Aug 25, 2021 · 2 comments
Labels
docs KDoc and API reference

Comments

@mohamadk
Copy link

I think this is unnecessary join since the timeout for the second job is int.max
also, it doesn't make sense in the context of this example to join the first job to the second because the sample tries to explain how two different cancellations can be totally independent

@mohamadk
Copy link
Author

also why this sample is not executable in the doc?

@qwwdfsad qwwdfsad added the docs KDoc and API reference label Aug 25, 2021
qwwdfsad added a commit that referenced this issue Aug 25, 2021
@qwwdfsad
Copy link
Member

This join is rather to explicitly show that the second coroutine executes after the first one has failed.
It's not really necessary indeed.

The sample is not executable because it was an oversight :)

pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this issue Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs KDoc and API reference
Projects
None yet
Development

No branches or pull requests

2 participants