Skip to content

asyncUI returns Unit, and not a future #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilya-g opened this issue Jun 23, 2016 · 1 comment
Closed

asyncUI returns Unit, and not a future #1

ilya-g opened this issue Jun 23, 2016 · 1 comment

Comments

@ilya-g
Copy link
Member

ilya-g commented Jun 23, 2016

This looks similar to async void methods in C#. Generally it's a discouraged practice with some exceptions.

I suggest to make it return at least CompletableFuture<Unit>

@elizarov
Copy link
Contributor

There is no more asyncUI. There's is a choice of future, launch, and defer primitives now.

XinyueZ added a commit to XinyueZ/kotlinx.coroutines that referenced this issue Sep 17, 2018
Run on java9(9.0.4)
The log(msg: String) doesn't work like the description in document.

`fun log(msg: String) = println("[${Thread.currentThread().name}] $msg")`

The output is not same like expected in document:

```
[main] Unconfined
[ForkJoinPool.commonPool-worker-2] Default
[main] main runBlocking
[MyOwnThread] newSingleThreadContext
[kotlinx.coroutines.DefaultExecutor] Unconfined
```
I change to:

`fun log(msg: String) = Thread.currentThread().run { println("[$name @coroutine#$id] $msg") }`

output:

```
[main @coroutineKotlin#1] Unconfined
[ForkJoinPool.commonPool-worker-2 @coroutineKotlin#15] Default
[main @coroutineKotlin#1] main runBlocking
[MyOwnThread @coroutineKotlin#17] newSingleThreadContext
[kotlinx.coroutines.DefaultExecutor @coroutineKotlin#13] Unconfined
```
XinyueZ added a commit to XinyueZ/kotlinx.coroutines that referenced this issue Sep 17, 2018
Run on java9(9.0.4)
The log(msg: String) doesn't work like the description in document.

`fun log(msg: String) = println("[${Thread.currentThread().name}] $msg")`

The output is not same like expected in document:

```
[main] Unconfined
[ForkJoinPool.commonPool-worker-2] Default
[main] main runBlocking
[MyOwnThread] newSingleThreadContext
[kotlinx.coroutines.DefaultExecutor] Unconfined
```
I change to:

`fun log(msg: String) = Thread.currentThread().run { println("[$name @coroutine#$id] $msg") }`

output:

```
[main @coroutineKotlin#1] Unconfined
[ForkJoinPool.commonPool-worker-2 @coroutineKotlin#15] Default
[main @coroutineKotlin#1] main runBlocking
[MyOwnThread @coroutineKotlin#17] newSingleThreadContext
[kotlinx.coroutines.DefaultExecutor @coroutineKotlin#13] Unconfined
```
qwwdfsad pushed a commit that referenced this issue Oct 23, 2020
…ss-tests

Add rx2/rx3 stress tests for ObservableSource.asFlow()
qwwdfsad added a commit that referenced this issue May 10, 2023
To address IDEA's responsiveness issues when reading/writing changelog

Commit #1 -- rename existing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants