Skip to content

Fix readRemaining #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Fix readRemaining #36

merged 1 commit into from
Feb 5, 2019

Conversation

e5l
Copy link
Member

@e5l e5l commented Feb 5, 2019

No description provided.

@e5l e5l requested a review from cy6erGn0m February 5, 2019 12:15
@e5l e5l self-assigned this Feb 5, 2019
@cy6erGn0m cy6erGn0m merged commit 64f1ada into master Feb 5, 2019
@cy6erGn0m cy6erGn0m deleted the e5l/read-fix branch February 5, 2019 12:22
@cy6erGn0m
Copy link
Contributor

Thanks!

@cy6erGn0m cy6erGn0m added this to the 0.1.5 milestone Feb 5, 2019
@cy6erGn0m
Copy link
Contributor

The fix is available in dev build 0.1.5-dev-4

@jrocharodrigues
Copy link

jrocharodrigues commented Feb 6, 2019

I had this issue ( Kotlin/kotlinx.serialization#360) when using serialization and ktor. Forced the use of kotlinx-io-0.1.5-dev-4 and org.jetbrains.kotlinx:kotlinx-coroutines-io-0.1.5-dev-4 and confirm this issue is solved.

However when using Ktor MockEngine to mock the the Json answer i got an error similar to the previous one i reported (the limit is different though) Invalid JSON at 4088: Unexpected end in string

Could this error be related to this issue, or should i open a new on for Ktor?

Thanks in advance

@e5l
Copy link
Member Author

e5l commented Feb 7, 2019

It looks like the separate issue from kx.io could you file an issue with reproducer or data sample?

@jrocharodrigues
Copy link

Ok, i have opened an issue in ktor, but i will close it, and open one in kx.io

@jrocharodrigues
Copy link

Done: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants