Skip to content

[Not for merge] Binaries #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

altavir
Copy link

@altavir altavir commented Mar 31, 2020

  • Introduce Binary (multi-read independent byte block) and implementation for Byte array and JVM Path.
  • Tests for them
  • Fix for readByteArray is broken #107
  • Add browser target

Some node tests are failing.

@@ -61,7 +61,7 @@ public fun Input.readByteArray(size: Int): ByteArray {
checkSize(size)

val result = ByteArray(size)
var position = size
var position = 0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line fixes #107

@altavir
Copy link
Author

altavir commented Apr 1, 2020

Oops, wrong file commited as fix for #107 . Added comment for the correct line.

@qwwdfsad qwwdfsad requested review from qwwdfsad and removed request for qwwdfsad April 3, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant