Reimplement datetime for Darwin in pure Kotlin #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the builds for different native targets are decoupled and it's possible to remove the workarounds that were needed to combine at times incompatible requirements imposed by different platforms.
The boundaries between the common native code and the platform-specific implementation is now less ad-hoc.
Before, some names mapping to fixed-offset timezones were parsed as `TimeZone` in Java and JS implementations, but `ZoneOffset` on Native.
Darwin calls the 0-offset timezones "GMT" while we preserve the name passed by the user.
The code that was written in Objective-C++ is now moved more or less verbatim to Kotlin. This is just the first stage of the port, as some things can be further simplified given how the boundaries between the platforms are no longer an issue.
ilya-g
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of HMPP allows providing a source-set for all the Darwin targets, which means that it's possible to avoid building an explicit bridge between the pure Kotlin implementation and native bindings for the corresponding platforms.
Additionally, use of cinterop is overall optimized by running it conditionally depending on the target platform. This makes it possible to get rid of C++ preprocessor magic almost entirely.