Skip to content

fix: missing isoDayOfWeek #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alfonsocv12
Copy link

@alfonsocv12 alfonsocv12 commented Mar 5, 2025

Reading to changes on PR 472 I thinks this were missing

@dkhalanskyjb
Copy link
Collaborator

I'd prefer to keep the internal variable named isoDayOfWeek: it's a numerical value, and there are several ways of assigning numbers to days, so it's nice to have it unambiguous.
The name of the dayOfWeek variable in the date container does get exposed to the user, so we are limited in what we can call it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants