Skip to content

Enable binary compatibility validation #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
882 changes: 882 additions & 0 deletions core/api/kotlinx-datetime.api

Large diffs are not rendered by default.

936 changes: 936 additions & 0 deletions core/api/kotlinx-datetime.klib.api

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ plugins {
id("org.jetbrains.dokka")
`maven-publish`
id("org.jetbrains.kotlinx.kover")
id("org.jetbrains.kotlinx.binary-compatibility-validator")
}

mavenPublicationsPom {
Expand Down Expand Up @@ -415,3 +416,10 @@ with(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootPlugin.apply(rootPr
nodeVersion = "21.0.0-v8-canary202309167e82ab1fa2"
nodeDownloadBaseUrl = "https://nodejs.org/download/v8-canary"
}

apiValidation {
@OptIn(kotlinx.validation.ExperimentalBCVApi::class)
klib {
enabled = true
}
}
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ defaultKotlinVersion=2.1.0
dokkaVersion=1.9.20
serializationVersion=1.6.2
benchmarksVersion=0.7.2
bcvVersion=0.17.0

java.mainToolchainVersion=8
java.modularToolchainVersion=11
Expand Down
2 changes: 2 additions & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ pluginManagement {
}
val dokkaVersion: String by settings
val benchmarksVersion: String by settings
val bcvVersion: String by settings
plugins {
id("org.jetbrains.dokka") version dokkaVersion
id("me.champeau.jmh") version benchmarksVersion
id("org.jetbrains.kotlinx.binary-compatibility-validator") version bcvVersion
}
}

Expand Down
8 changes: 8 additions & 0 deletions timezones/full/api/kotlinx-datetime-zoneinfo.klib.api
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// Klib ABI Dump
// Targets: [wasmWasi]
// Rendering settings:
// - Signature version: 2
// - Show manifest properties: true
// - Show declarations: true

// Library unique name: <org.jetbrains.kotlinx:kotlinx-datetime-zoneinfo>
8 changes: 8 additions & 0 deletions timezones/full/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ plugins {
kotlin("multiplatform")
id("maven-publish")
id("com.github.node-gradle.node") version "7.0.2"
id("org.jetbrains.kotlinx.binary-compatibility-validator")
}

node {
Expand Down Expand Up @@ -89,3 +90,10 @@ kotlin {
}
}
}

apiValidation {
@OptIn(kotlinx.validation.ExperimentalBCVApi::class)
klib {
enabled = true
}
}