Common: add Instant.fromEpochSeconds(Long, Int) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overload allows to pass an Int as the number of nanoseconds.
dkhalanskyjb
force-pushed
the
instantFromSecondsInt
branch
from
2d767a5 to
0e24ce7
Compare
ilya-g
reviewed
Sep 9, 2020
core/jsMain/src/mathJs.kt
Outdated
| * This returns {@code -1} for {@code floorDiv(-2, 4)}.<br /> | ||
| * This returns {@code -1} for {@code floorDiv(-3, 4)}.<br /> | ||
| * This returns {@code -1} for {@code floorDiv(-4, 4)}.<br /> | ||
| * This returns {@code -2} for {@code floorDiv(-5, 4)}.<br /> |
There was a problem hiding this comment.
Do not use {@code} and <br> tags in kdocs.
There was a problem hiding this comment.
Fixed, and also removed such constructs where they were copied from.
ilya-g
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overload allows to pass an Int as the number of nanoseconds.