-
Notifications
You must be signed in to change notification settings - Fork 110
No longer make Month and DayOfWeek type aliases on the JVM #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52dac5a
to
2e1c4f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we discussed this change, but cannot find the document.
I actually don't remember us discussing this change. We mentioned this issue recently while discussing UUIDs and whether to make them type aliases on the JVM. If you have doubts about this change, we can hold a meeting. What led me to go and implement this is that |
Yes, there are some arguments for this change, like exhaustiveness of matching over expected enum entries and being able to provide companion for static extensions (though these shortcomings will be eventually fixed in Kotlin). On the other hand, this is a binary breaking change. |
c75d582
to
090a01d
Compare
090a01d
to
589dbbd
Compare
@ilya-g, PTAL at the last commit. |
Fixes #96