Use java toolchains to setup JDK 8 path #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
commented
Nov 8, 2021
Remove commented out JVM 6 target.
ilya-g
force-pushed
the
toolchains
branch
3 times, most recently
from
1b0236d to
fd975db
Compare
dkhalanskyjb
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Checked that the jvmTest for both subprojects runs on Linux and MacOS, whether or not the environment variables are set. Also, on Linux, the project builds in general.
For some reason, on the Mac laptop, even though it's not ARM-based, the build attempts to also run tests for the arm64 targets, which fails the build for me, but the same also happens on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove commented out JVM 6 target.