Skip to content

Enable support for watchosX64 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable support for watchosX64 #119

wants to merge 2 commits into from

Conversation

goncalossilva
Copy link

@goncalossilva goncalossilva commented May 20, 2021

Supersedes #93, with the changes:

  • Enables watchosX64 in both modules, not just core.
  • Rebased from master, fixing inconsistencies with the stdlib (1.4.30 and 1.5.0 are source-incompatible, hence the CI failure in Support x86_64-based watchOS simulator target #93).
  • The above enables switching to kotlinx.serialization 1.2.1 (watchosX64 is only supported on 1.2.0 and up).
  • Simplified setup, with kotlinx.serialization being declared only once.
  • Test suite should be green, but I can't trigger TeamCity. 😄

@goncalossilva
Copy link
Author

Is there any chance this might be reviewed soon?

We have an internal milestone by the end of the month that needs this... We can package and publish this internally for demonstration purposes, but if we have a chance to work with the official build, we'd take it. Thanks!

@dkhalanskyjb
Copy link
Collaborator

Simplified setup, with kotlinx.serialization being declared only once.

The complex setup that we have is intentional. Its purpose is so that the JVM version doesn't introduce a dependency on the serialization library. So, we have to make it work with a compileOnly dependency in the common code.

We will need to make a new release in order to fix #118, and watchosX64 support would likely fit there nicely, so, if everything goes well, we'll have a release by the end of the week that introduces it.

@goncalossilva
Copy link
Author

goncalossilva commented May 25, 2021

Simplified setup, with kotlinx.serialization being declared only once.

The complex setup that we have is intentional. Its purpose is so that the JVM version doesn't introduce a dependency on the serialization library. So, we have to make it work with a compileOnly dependency in the common code.

That should be an easy change, but it's probably not worth it if you're planning to fix it as part of #118?

@goncalossilva
Copy link
Author

Changes in #120.

@goncalossilva goncalossilva deleted the watchosx64 branch May 25, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants