Fix breaking builds on Native due to depending on serialization #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like `compileOnly` doesn't, in fact, ensure that there is no runtime dependency, as Kotlin/Native does not support that. Thus, it looks like `compileOnly` transforms into something like `api` in a contrived manner, which leads to the tests implicitly acquiring a runtime dependency. Therefore, the changes: * There is now a separate artifact for serialization. * The datetime classes are no longer marked as @serializable and don't have default serializers. * The package name for serializers is now "kotlinx.datetime.serialization", as it makes sense for it to be similar to the name of the artifact, and an artifact with the name "serializers" would look odd.
|
But that also means that you now always have to put a @contextual above any kx.datetime property |
|
Closed in favor of #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
compileOnlydoesn't, in fact, ensure that there is noruntime dependency, as Kotlin/Native does not support that. Thus,
it looks like
compileOnlytransforms into something likeapiina contrived manner, which leads to the tests implicitly acquiring
a runtime dependency.
Therefore, the changes:
@Serializableanddon't have default serializers.
"kotlinx.datetime.serialization", as it makes sense for it to be
similar to the name of the artifact, and an artifact with the
name "serializers" would look odd.