Skip to content

Incorrect return value of DateTimePeriod.toString() #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkhalanskyjb opened this issue Dec 4, 2020 · 0 comments
Closed

Incorrect return value of DateTimePeriod.toString() #79

dkhalanskyjb opened this issue Dec 4, 2020 · 0 comments

Comments

@dkhalanskyjb
Copy link
Collaborator

dkhalanskyjb commented Dec 4, 2020 •
edited
Loading 

DateTimePeriod(nanoseconds = 999_999_999_999_999L) // PT0.999999999999999S
DateTimePeriod(seconds = 1L, nanoseconds = -1L) // PT1.0000000-1S
dkhalanskyjb added a commit that referenced this issue Dec 11, 2020
@dkhalanskyjb
Change DateTimePeriod to be normalized
ca832d4 
Now, it only has three components: months, days, and nanoseconds,
and all the other properties are just representations of these
ones.

This way, for each DateTimePeriod there exists a well-defined
ISO-8601 representation, and `toString()` behaves correctly.

Fixes #79
@ilya-g ilya-g mentioned this issue Dec 11, 2020
Closed
dkhalanskyjb added a commit that referenced this issue Jan 19, 2021
@dkhalanskyjb
Change DateTimePeriod to be normalized
5947748 
Now, it only has three components: months, days, and nanoseconds,
and all the other properties are just representations of these
ones.

This way, for each DateTimePeriod there exists a well-defined
ISO-8601 representation, and `toString()` behaves correctly.

Fixes #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkhalanskyjb