Skip to content

Add $ref support for ComboBox + some optimization #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

almirus
Copy link

@almirus almirus commented Mar 11, 2018

code deduplication and add $ref support for ComboBox

add $ref support (external resource) for ComboBox
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 91.134% when pulling 1a9a127 on almirus:master into 2959ba2 on JsonSchema-JavaUI:dev.

Copy link
Member

@SaifJerbi SaifJerbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work to improve the code quality and remove code duplication

@SaifJerbi SaifJerbi merged commit 4145562 into JsonSchema-JavaUI:dev Mar 11, 2018
@SaifJerbi
Copy link
Member

Hi @almirus,
Thanks for your contribution,
Could you please update the documentation and describe the new added property ?

@almirus
Copy link
Author

almirus commented Mar 12, 2018

I do not speak English well.
Examples for $ref:
https://github.com/json-schema-form/angular-schema-form/blob/bd182950b78c68ac3556b399fbaf3e3ea9a33232/examples/data/jsonref.json
json-schema-form/json-schema-form-core#1

It may be necessary to add support $ref for all fields

@SaifJerbi
Copy link
Member

I found the combo box and the check box documentation aren't published yet, so i will add this property in the doc and publish that ASAP.
Don't hesitate if you find any improvement to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants