Skip to content
This repository was archived by the owner on Jun 6, 2019. It is now read-only.

Update to Kotlin 1.3.11 and coroutines 1.0.1 #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update to Kotlin 1.3.11 and coroutines 1.0.1 #34

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3edad2
Update to Kotlin 1.3.0 and coroutines 1.0.0 from mavenCentral instead…
bradynpoulsen Oct 29, 2018
586a9e2
Update to 1.0.0-SNAPSHOT
bradynpoulsen Oct 29, 2018
d8ad9ca
Migrate CompletableDeferred.isCompletedExceptionally to its deprecati…
bradynpoulsen Oct 29, 2018
4b32e53
Cancel the Call if the Deferred is completed by a CancellationException
bradynpoulsen Oct 29, 2018
275fa37
Update to Kotlin 1.3.11 and coroutines 1.0.1
bradynpoulsen Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/com/jakewharton/retrofit2/adapter/kotlin/coroutines/CancelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class CancelTest {
val deferred = adapter.adapt(call)
call.completeWithException(IOException())
assertFalse(call.isCanceled)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call is cancelled in coroutines 0.27.0+ because CompletedExceptionally is considered a "cancelled" state

assertTrue(deferred.isCompletedExceptionally)
assertTrue(deferred.isCancelled && deferred.isCompleted)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Deferred in coroutines 0.27.0 for more details

}

@Test fun cancelOnCancel() {
Expand Down