Fix bug in sort-styles when props included shorthands #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the style properties had a 'isEitherShorthand' case, it would return out of the whole checkIsSorted function instead of continuing the for loop. This caused some properties to not be reported as unsorted. It would be sufficient to replace `return` with `continue`, but there was a ESLint rule disallowing the usage of continue
|
thanks @draperunner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the style properties had a 'isEitherShorthand' case, it would return out of the whole checkIsSorted function instead of continuing the for loop. This caused some properties to not be reported as unsorted.
It would be sufficient to replace
returnwithcontinue, but there was a ESLint rule disallowing the usage of continue.I added a new test case for this scenario.