fix: rule/no-single-element-style-arrays - exception when style prop is not an expression #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we could get this unblocked? Anything I can do to help get it landed? |
|
Why is this not merged yet? |
|
Oh wow, I just realized this got merged, thanks @Intellicode! Any chance we could get a release on npm? Anything I could do to help with this? I'm happy to pitch in maintaining this package if you want |
|
@sstur Sorry for the delay, I have to make a release yes :) hopefully this weekend, or earlier if I remember. I definitely need help for maintenance, especially since I do not use react native myself anymore. However, I'm not sure yet how I want to set that up yet. |
|
@sstur I have released a new version, let me know if there are any problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when a React Native component has style prop that can be a string.
The most notable example of this is the default
App.js(or App.tsx) in a new React Native app (initialized usingexpo init, as recommended by the RN docs). It looks like this:Notice line 9 which contains:
<StatusBar style="auto" />That causes the following exception when running
eslint: