Skip to content

Added support of other style sheet providers (eg EStyleSheet) #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2018
Merged

Added support of other style sheet providers (eg EStyleSheet) #207

merged 3 commits into from
Nov 22, 2018

Conversation

xxsnakerxx
Copy link
Contributor

@coveralls
Copy link

coveralls commented Nov 8, 2018

Coverage Status

Coverage increased (+0.2%) to 73.207% when pulling dbd5d77 on xxsnakerxx:EStyleSheet-support into e351e4f on Intellicode:master.

@Intellicode
Copy link
Owner

@xxsnakerxx thanks for your PR! Would it however be possible to make the StyleSheet match configurable rather than an includes match?

@xxsnakerxx
Copy link
Contributor Author

Great idea! We can add a setting for the plugin, we can name it something like react-native/style-sheet-object-names. By default, it will be ['StyleSheet'] and a user can override this in the config

...
settings: {
    'react-native/style-sheet-object-names': ['EStyleSheet', 'OtherStyleSheet']
}
...

Do you agree?

@Intellicode
Copy link
Owner

@xxsnakerxx yeah looks good, very nice :D I'll create a release this weekend!

@Intellicode Intellicode merged commit 1d18f84 into Intellicode:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants