Fix cppcheck errors #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaenrig-ifx
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
I fail to yet see the patterns in the formatting. I assume it is just a matter of working with this configuration and after a few automatic corrections and file navigation you see learn the format.
If at some point still the format feels a bit arbitrary, and we still doubt how to write it manually, we have to review it. That will mean the code does not speak for itself, and clearly shows which is the convention (and the favored style and rationale behind).
jaenrig-ifx
reviewed
Apr 7, 2025
ramya-subramanyam
force-pushed
the
devops-code-check-tools
branch
from
820faf4 to
ae164b7
Compare
Signed-off-by: Ramya Subramanyam <[email protected]>
Signed-off-by: Ramya Subramanyam <[email protected]>
Signed-off-by: Ramya Subramanyam <[email protected]>
Signed-off-by: Ramya Subramanyam <[email protected]>
Signed-off-by: Ramya Subramanyam <[email protected]>
ramya-subramanyam
force-pushed
the
fix-cppcheck-errors
branch
from
273961a to
99aa046
Compare
|
All good! Re-reviewed! |
Signed-off-by: Ramya Subramanyam <[email protected]>
ramya-subramanyam
force-pushed
the
fix-cppcheck-errors
branch
from
f207c1e to
689cfb4
Compare
ramya-subramanyam
merged commit fc0f5b5
into
devops-code-check-tools
12 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
fixed following erros:
https://github.com/Infineon/arduino-core-psoc6/actions/runs/14018411488