Skip to content

Possible Exercises #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2020
Merged

Possible Exercises #12

merged 4 commits into from
Jan 31, 2020

Conversation

shhavel
Copy link
Contributor

@shhavel shhavel commented Nov 14, 2019

Possible exercises (without solutions).

tshemsedinov
tshemsedinov requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution, all tasks are good, need some improvements.
To land this we need to rebase on master and reorder examples.
But let's fix everything and after I will approve all changes we will rebase and reorder.

@shhavel
Copy link
Contributor Author

shhavel commented Jan 6, 2020

Thanks for review. Fixed PR comments.

tshemsedinov
tshemsedinov reviewed Jan 6, 2020
View reviewed changes
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 one more round

@shhavel shhavel requested a review from tshemsedinov January 11, 2020 00:26
@tshemsedinov
Copy link
Member

Now it's time to reorder examples to avoid conflicts with master and then I'll land this PR @shhavel

@shhavel
Possible Exercises
10c753b
@shhavel
Change curry exercise
c0d310e
@shhavel
PR comments:
5d35a4a 
- use new hpw;
- remove setting names for anonymous functions for old hpw; 
- remove unnecessary parentheses;
- refactor constructing current date string.
@shhavel
PR comments. Move expected pin code out of checkPin function
e91b30a
@shhavel shhavel force-pushed the possible_exercises branch from f84b9c2 to e91b30a Compare January 30, 2020 11:55
@shhavel
Copy link
Contributor Author

shhavel commented Jan 30, 2020 •
edited
Loading

@tshemsedinov Branch was rebased with master. Examples were reordered (they now start from 2). Thanks.

@tshemsedinov tshemsedinov merged commit 17e04e4 into HowProgrammingWorks:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshemsedinov tshemsedinov tshemsedinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shhavel @tshemsedinov