Skip to content

Adding parse errors for tag name state #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2017

Conversation

diervo
Copy link

@diervo diervo commented Apr 6, 2017

Tag Name state parse errors:
https://html.spec.whatwg.org/multipage/syntax.html#tag-name-state:

  • Added unexpected-eof-character
  • Added unexpected-null-character

@diervo
Copy link
Author

diervo commented Apr 6, 2017

@inikulin I haven't included the tests failures for this pr (there are 3) because right now we have like ~200 failing, do you want me to fix those as well?

@inikulin
Copy link
Member

inikulin commented Apr 6, 2017

@diervo Are you sure you rebased on top of latest version of html5lib-tests? Where should be no failures, except whose that affected by your change (you can see it in CI results)

@diervo
Copy link
Author

diervo commented Apr 6, 2017

Running the update.sh Im running into a rebase issue in html from upstream. Other than that, I'm using master from HTMLParseErrorWG in all 3 projects. I don't see the linking between parse5 and htmlt5lib-tests. What am I doing wrong?

@inikulin
Copy link
Member

inikulin commented Apr 6, 2017

Master branch of parse5 from this org looks for tests in html5lib-tests dir which is in the same level as parse5 dir, e.g.: https://github.com/HTMLParseErrorWG/parse5/blob/master/test/fixtures/tokenizer_test.js#L190

Check that your update.sh contains this line: https://gist.github.com/inikulin/b8a9eea7fee5e3438925fb5a3981e777#file-update-sh-L28 I recall adding it later, but I'm not sure if it was before I wrote workflow instructions. Try run update.sh and carefully examine output for rebase/pull errors.

@diervo
Copy link
Author

diervo commented Apr 6, 2017

@inikulin All good, got everything working (I had manually run pull in parse5 so it was not in sync)
That being said, I do see a rebase (from upstream/master) conflict in html, but we could resolve that later.

Will do the requested changes for the eof error as well.

@diervo
Copy link
Author

diervo commented Apr 7, 2017

@inikulin Last dependency of the three to merge.

@inikulin inikulin merged commit a68c520 into HTMLParseErrorWG:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants