Skip to content

Review fixes2 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2017
Merged

Review fixes2 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5765c84
Rename abrupt closing of comment error
inikulin May 30, 2017
eae4e2d
non-void-element -> non-void-html-element
inikulin May 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tokenizer/escapeFlag.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"input":"foo<!--></xmp><!-->baz</xmp>",
"output":[["Character", "foo<!-->"], ["EndTag", "xmp"], ["Comment", ""], ["Character", "baz"], ["EndTag", "xmp"]],
"errors":[
{ "code": "abrupt-closing-of-comment", "line": 1, "col": 19 }
{ "code": "abrupt-closing-of-empty-comment", "line": 1, "col": 19 }
]},

{"description":"Commented entities in RCDATA",
Expand Down
4 changes: 2 additions & 2 deletions tokenizer/test1.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,15 @@
"input":"<!-->",
"output":[["Comment", ""]],
"errors":[
{ "code": "abrupt-closing-of-comment", "line": 1, "col": 5 }
{ "code": "abrupt-closing-of-empty-comment", "line": 1, "col": 5 }
]},


{"description":"Short comment two",
"input":"<!--->",
"output":[["Comment", ""]],
"errors":[
{ "code": "abrupt-closing-of-comment", "line": 1, "col": 6 }
{ "code": "abrupt-closing-of-empty-comment", "line": 1, "col": 6 }
]},

{"description":"Short comment three",
Expand Down
4 changes: 2 additions & 2 deletions tree-construction/comments01.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ FOO<!--->BAZ
(1,3): expected-doctype-but-got-chars
(1,9): incorrect-comment
#new-errors
(1:9) abrupt-closing-of-comment
(1:9) abrupt-closing-of-empty-comment
#document
| <html>
| <head>
Expand All @@ -121,7 +121,7 @@ FOO<!-->BAZ
(1,3): expected-doctype-but-got-chars
(1,8): incorrect-comment
#new-errors
(1:8) abrupt-closing-of-comment
(1:8) abrupt-closing-of-empty-comment
#document
| <html>
| <head>
Expand Down
10 changes: 5 additions & 5 deletions tree-construction/foreign-fragment.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ math ms
52: End of file seen and there were open elements.
51: Unclosed element “ms”.
#new-errors
(1:44-1:49) non-void-element-start-tag-with-trailing-solidus
(1:44-1:49) non-void-html-element-start-tag-with-trailing-solidus
#document-fragment
math ms
#document
Expand Down Expand Up @@ -218,7 +218,7 @@ math ms
52: End of file seen and there were open elements.
51: Unclosed element “mn”.
#new-errors
(1:44-1:49) non-void-element-start-tag-with-trailing-solidus
(1:44-1:49) non-void-html-element-start-tag-with-trailing-solidus
#document-fragment
math mn
#document
Expand Down Expand Up @@ -261,7 +261,7 @@ math mn
52: End of file seen and there were open elements.
51: Unclosed element “mo”.
#new-errors
(1:44-1:49) non-void-element-start-tag-with-trailing-solidus
(1:44-1:49) non-void-html-element-start-tag-with-trailing-solidus
#document-fragment
math mo
#document
Expand Down Expand Up @@ -304,7 +304,7 @@ math mo
52: End of file seen and there were open elements.
51: Unclosed element “mi”.
#new-errors
(1:44-1:49) non-void-element-start-tag-with-trailing-solidus
(1:44-1:49) non-void-html-element-start-tag-with-trailing-solidus
#document-fragment
math mi
#document
Expand Down Expand Up @@ -347,7 +347,7 @@ math mi
52: End of file seen and there were open elements.
51: Unclosed element “mtext”.
#new-errors
(1:44-1:52) non-void-element-start-tag-with-trailing-solidus
(1:44-1:52) non-void-html-element-start-tag-with-trailing-solidus
#document-fragment
math mtext
#document
Expand Down
4 changes: 2 additions & 2 deletions tree-construction/tests1.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,8 @@ Line1<br>Line2<br>Line3<br>Line4
(1,17): incorrect-comment
(1,17): expected-closing-tag-but-got-eof
#new-errors
(1:5) abrupt-closing-of-comment
(1:17) abrupt-closing-of-comment
(1:5) abrupt-closing-of-empty-comment
(1:17) abrupt-closing-of-empty-comment
#document
| <!-- -->
| <html>
Expand Down
2 changes: 1 addition & 1 deletion tree-construction/webkit01.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ console.log("FOO<span>BAR</span>BAZ");
(1,23): non-void-element-with-trailing-solidus
(1,29): end-tag-too-early
#new-errors
(1:9-1:24) non-void-element-start-tag-with-trailing-solidus
(1:9-1:24) non-void-html-element-start-tag-with-trailing-solidus
#document
| <html>
| <head>
Expand Down