fix: use empty string path when function source is not specified #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… var are not specified I removed '/' from CODE_LOCATION that set the default function directory to root in commit #77. This causes this error in 1.3.0, ``` npx @google-cloud/functions-framework --target=helloWorld The "path" argument must be of type string. Received type undefined ``` When --source flag and FUNCTION_SOURCE env var are not specified, one of the 'path' arguments in resolve() is undefined. This causes the error above. I've added empty string as an argument in the case above. This should fix the bug.
hdp617
changed the title
lukasberger
reviewed
Sep 13, 2019
src/index.ts
Outdated
| @@ -63,7 +63,7 @@ const argv = minimist(process.argv, { | |||
|
|
|||
| const CODE_LOCATION = resolve( | |||
| process.cwd(), | |||
There was a problem hiding this comment.
Isn't process.cwd redundant here? According to the docs [1] the cwd is prepended to any relative path.
https://nodejs.org/docs/latest/api/path.html#path_path_resolve_paths
There was a problem hiding this comment.
It is redundant. I thought the docs meant cwd would be used as a path instead of cwd being prepended.
lukasberger
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
'/'fromCODE_LOCATIONthat set the default function directory to root in commit #77. This causes this error in 1.3.0,When
--sourceflag andFUNCTION_SOURCEenv var are not specified, one of the 'path' arguments inresolve()is undefined. This causes the error above.I've added empty string as an argument in the case above.
fixes issue #89