Skip to content

fix: if execution id support requested for node 12, fail open and drop execution id support instead of crashing out #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2024
Merged

fix: if execution id support requested for node 12, fail open and drop execution id support instead of crashing out #618

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fbb097
fix: if execution id support requested for node 12, fail open and dro…
jrmfg Jul 8, 2024
aba5cea
lint
jrmfg Jul 8, 2024
bd87854
test
jrmfg Jul 8, 2024
d9ab277
lint
jrmfg Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,11 @@
(typeof x === 'boolean' && x) ||
(typeof x === 'string' && x.toLowerCase() === 'true');
if (isTrue && !isVersionSatisfied) {
throw new OptionsError(
`Execution id is only supported with Node.js versions ${requiredNodeJsVersionForLogExecutionID} and above. Your current version is ${nodeVersion}. Please upgrade.`
);
console.warn(
`Execution id is only supported with Node.js versions ${requiredNodeJsVersionForLogExecutionID} and above. Your current version is ${nodeVersion}. Please upgrade.`);

Check failure on line 150 in src/options.ts

View workflow job for this annotation

GitHub Actions / lint 

Insert `⏎······`
console.warn(

Check failure on line 151 in src/options.ts

View workflow job for this annotation

GitHub Actions / lint 

Delete `⏎········`
`Proceeding with execution id support disabled...`);

Check warning on line 152 in src/options.ts

View workflow job for this annotation

GitHub Actions / lint 

Strings must use singlequote
return false;
}
return isTrue;
}
Expand Down
Loading