Skip to content

Revert "Disable Express eTag response header for consistent FF behaviour across FF runtimes " #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

Revert "Disable Express eTag response header for consistent FF behaviour across FF runtimes " #438

merged 1 commit into from
Mar 31, 2022

Conversation

grant
Copy link
Contributor

@grant grant commented Mar 31, 2022 •
edited
Loading

Reverts #433 due to failed lint check.

anniefu
anniefu approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@anniefu anniefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add in the PR description a short blurb about why we are reverting.

@grant
Copy link
Contributor Author

grant commented Mar 31, 2022

Would add in the PR description a short blurb about why we are reverting.

Sure thing, done!

@grant grant merged commit 957320b into master Mar 31, 2022
@grant grant deleted the revert-433-master branch March 31, 2022 20:51
grant added a commit that referenced this pull request Mar 31, 2022
@grant
Revert "Revert "Disable Express eTag response header for consistent F…
6f466e4 
…F behaviour across FF runtimes (#433)" (#438)"

This reverts commit 957320b.
grant added a commit that referenced this pull request Mar 31, 2022
@grant
feat: Disable Express eTag response header for consistent FF behaviou…
07668f6 
…r across FF runtimes (#439)

* Revert "Revert "Disable Express eTag response header for consistent FF behaviour across FF runtimes  (#433)" (#438)"

This reverts commit 957320b.

* lint: update newlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniefu anniefu anniefu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @anniefu