-
Notifications
You must be signed in to change notification settings - Fork 167
Inline Dockerfile and gcloud commands. #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Dockerfile and gcloud commands to README. It isn't clear how to deploy the same function to all three environments, Cloud Functions, Cloud Run and Cloud Run on GKE. What's missing is a Dockerfile and example gcloud commands. There are links to the relevant quickstarts, but it made me think I was in the wrong place.
@josephburnett Thanks for the PR, this is very useful. For example, I think this In addition, I don't think we want to tie the functions framework to |
+1 to grant's comment. IMO this belongs in a Medium/blog post rather than as content that we own and maintain. What if we posted this elsewhere and just linked to it from the repo (e.g., "here's a collection of great links that show you how to do things with the Functions Framework")? |
All this info is really useful, maybe can be added as Wiki pages here on GitHub so it's easier to find. A few important things about using the functions framework were quite tricky to do, and found the info in closed issues.. |
@AndreiIgna Please link or re-open the issues if you think we should add them in docs. |
@stew-r Up to you. I think critical docs should be part of the repo, like how to configure a Dockerfile to use this module, should be in this repo rather than our community docs. For example in |
@josephburnett Could you move the contents of this PR into the new |
@josephburnett Do you want to make the changes (move to |
FYI, I've created a PR that moves this change to the |
Add Dockerfile and gcloud commands to README.
It isn't clear how to deploy the same function to all three environments, Cloud Functions, Cloud Run and Cloud Run on GKE. What's missing is a Dockerfile and example gcloud commands. There are links to the relevant quickstarts, but it made me think I was in the wrong place.