Skip to content

docs: remove incorrect pubsub docs #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

docs: remove incorrect pubsub docs #145

merged 1 commit into from
Jun 2, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented May 28, 2020 •
edited
Loading

The current docs are incorrect. We don't have a replacement just yet.
See #96 #41

@grant grant requested a review from ace-n May 28, 2020 17:45
@grant grant self-assigned this May 28, 2020
@grant
Copy link
Contributor Author

grant commented Jun 2, 2020 •
edited
Loading

Pinged on Chat. @ace-n

ace-n
ace-n approved these changes Jun 2, 2020
View reviewed changes
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as a short-term change, but we should try to properly document this in the future.

@grant
Copy link
Contributor Author

grant commented Jun 2, 2020

Yeah, we should add doc here when we get a correct guide.

@grant grant merged commit a574422 into master Jun 2, 2020
@grant grant deleted the grant-pubsub-docs branch June 2, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees

@grant grant

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grant @ace-n @googlebot