Skip to content

Tests: Use valid values for test CloudEvent #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grant opened this issue May 4, 2020 · 0 comments
Closed

Tests: Use valid values for test CloudEvent #133

grant opened this issue May 4, 2020 · 0 comments
Assignees
@hdp617

Comments

@grant
Copy link
Contributor

grant commented May 4, 2020

The CloudEvents test uses invalid dummy data for it's CE payload.

For example, 'ce-specversion': 'testSpecversion', is not valid as testSpecversion is not a valid version.

https://github.com/GoogleCloudPlatform
/functions-framework-nodejs/blob/master/test/invoker.ts#L186
@hdp617 hdp617 self-assigned this May 7, 2020
hdp617 added a commit that referenced this issue May 14, 2020
@hdp617
Use CloudEvents v1.0 in CloudEventsContext and tests (#139)
bf6e20e 
* docs: Fix link to the CloudEvents spec

* fix: Use CloudEvents v1.0 in CloudEventsContext and tests

CloudEvents v1.0 has renamed `schemaurl` to `dataschema` and `contenttpye` to `datacontenttype` and added subject. `CloudEventsContext` is updated with the v1.0 attributes.
CloudEvents tests are also updated to use valid values.

Resolves: #132, #133

* fix: Remove the dataschema attribute

The current value is not the true dataschema of the payload.
@hdp617 hdp617 closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hdp617 hdp617

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grant @hdp617