Fixes #2122 - sequence contains no elements when using IgnoreConfig #2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
requested changes
Jun 11, 2020
…ub.com/DamianKedzior/GitVersion into bug/2122-sequence-contains-no-elements
asbjornu
approved these changes
Jun 14, 2020
|
Thank you so much for your contribution, @DamianKedzior! 🙏 |
|
@asbjornu glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using IgnoreConfig and ignoring all commits to start from scratch (from 0.1.0) all version strategies were ignored, including Fallback one. This was causing sequence contains no elements exception.
Description
Change I made excludes VersionFilters for FallbackVersionStrategy.
Related Issue
#2122
Motivation and Context
When forking existing repo which contains tags with version numbers and trying to start versioning from scratch you could specify
IgnoreConfigto skip previous commits. Currently this is not possible because it throws exception.How Has This Been Tested?
There is new integration tests added for this scenario.
Screenshots (if appropriate):
Checklist: