-
-
Notifications
You must be signed in to change notification settings - Fork 171
Added fixes for imports. #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6220163
Added fixes for imports.
Reedyuk 2f56a62
Adjusted api dump.
Reedyuk a033138
Adjusted import to import as
Reedyuk f8ae8dd
Merge branch 'master' into android-imports
Reedyuk 1ad7fef
Added import as Platform
Reedyuk 8310e6c
Apply automatic changes
Reedyuk 8e2d6a0
Adjusted readme
Reedyuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...ore/src/androidMain/kotlin/dev/gitlive/firebase/firestore/internal/callbackExecutorMap.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
package dev.gitlive.firebase.firestore.internal | ||
|
||
import com.google.firebase.firestore.FirebaseFirestore | ||
import java.util.concurrent.ConcurrentHashMap | ||
import java.util.concurrent.Executor | ||
|
||
// Since on iOS Callback threads are set as settings, we store the settings explicitly here as well | ||
internal val callbackExecutorMap = ConcurrentHashMap<FirebaseFirestore, Executor>() | ||
internal val callbackExecutorMap = ConcurrentHashMap<com.google.firebase.firestore.FirebaseFirestore, Executor>() |
5 changes: 3 additions & 2 deletions
5
firebase-perf/src/androidMain/kotlin/dev/gitlive/firebase/perf/metrics/Trace.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 2 additions & 4 deletions
6
firebase-perf/src/androidMain/kotlin/dev/gitlive/firebase/perf/session/PerfSession.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
package dev.gitlive.firebase.perf.session | ||
|
||
import com.google.firebase.perf.session.PerfSession | ||
public val PerfSession.android: com.google.firebase.perf.session.PerfSession get() = android | ||
|
||
public val PerfSession.android: PerfSession get() = android | ||
|
||
public class PerfSession internal constructor(internal val android: PerfSession) | ||
public class PerfSession internal constructor(internal val android: com.google.firebase.perf.session.PerfSession) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.