➕ Add iosSimulatorArm64 target, introduced in KMM 1.5.30 #220
Conversation
⬆️ Bump kotlinx-coroutines to 1.5.2 (which adds the same targets) ⬆️ Bump kotlinx-serialization to 1.3.0-RC (which adds the same targets)
|
@Reedyuk is this something you would be able to review? 🙏 |
| @@ -44,6 +44,13 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| val KonanTarget.archVariant: String | |||
| get() = if (this is KonanTarget.IOS_X64 || this is KonanTarget.IOS_SIMULATOR_ARM64) { | |||
| "ios-arm64_i386_x86_64-simulator" | |||
There was a problem hiding this comment.
As I understand it, this slice should be correct for x86 and arm simulators
There was a problem hiding this comment.
🚨 This doesn't build locally - the issue appears to be at the :firebase-app:cinteropFirebaseCoreIosArm64 task, which I don't quite understand how to get a verbose output from as it runs in another Java process (I'm probably past my level of understanding here 😅).
I've pushed the changes anyway in case there is something obvious I have missed? @Reedyuk
There was a problem hiding this comment.
@pauldavies83 It compiles in my machine. I've had that error happen to me a number of times because of cinterop tasks caching incorrectly. Try Clean Project, it usually fixes it :)
There was a problem hiding this comment.
🤔 Hmmm, I get the same error after a clean...
./gradlew clean build --no-build-cache
I found an issue from reading the CI log anyway, which I've fixed here
|
Could you please create new release with this? |
➕ Add iosSimulatorArm64 target, introduced in KMM 1.5.30
⬆️ Bump kotlinx-coroutines to 1.5.2 (which adds the same targets)
⬆️ Bump kotlinx-serialization to 1.3.0-RC (which adds the same targets)
This should resolve #218 , as the iOS arm64 simulator target will now output the correct framework slice for that device.