-
Notifications
You must be signed in to change notification settings - Fork 168
Fix iOS tests, upgrade iOS Firebase SDK #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cant we skip the ios tests at the build script instead of at the test level @shepeliev @Reedyuk ? |
Yeah we could add something to skip ios tests in the build gradle if you want this? |
@Reedyuk yeah as that will a lot easier to maintain that at code level, but its just the auth tests we want to skip correct? |
@shepeliev last time I checked I thought the ios test didn't work at all - they just froze, in fact the
Are you saying this actually works now? |
Looks like it was an accurate guess ) because it works for me. Actually, I'm a newbie in KMP and Android background, so I can't say if iOS |
After updating Firebase iOS SDK some tests fail because
ld
could not find the required frameworks.Another problem, FirebaseFirestore 8.1.0 has Carthage bug that is the cause of missing gRPC-C++ framework. This PR fixes these issues. Also, I've enabled iOS testing at GitHub actions. Unfortunately, auth tests fail on iOS simulator, therefore I've added a skip flag for ignoring tests on iOS.