Skip to content

build config changes #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2021
Merged

build config changes #151

merged 3 commits into from
Feb 24, 2021

Conversation

suntrix
Copy link
Contributor

@suntrix suntrix commented Feb 16, 2021

@suntrix
build config changes
f72b47c 
* updated iosMain/c_interop to nativeInterop/cinterop (fixes #139)
* hierarchical project structure (#137)
* gradle cleanup & enabled parallel builds
@suntrix
fixes
730df0f
@suntrix
cleanup
4e6b0f0
@suntrix
Copy link
Contributor Author

suntrix commented Feb 18, 2021

@nbransby I think it's ready for review now.

Not sure why the JS tests in GutHub Actions do not work sometimes... https://github.com/GitLiveApp/firebase-kotlin-sdk/runs/1922796121

@suntrix
Copy link
Contributor Author

suntrix commented Feb 23, 2021

@Reedyuk can this be reviewed?

@nbransby nbransby merged commit 6d339de into GitLiveApp:master Feb 24, 2021
@suntrix suntrix deleted the modern-native-interop-config branch February 24, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reedyuk Reedyuk Reedyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use more modern src/nativeInterop/cinterop way to import iOS frameworks
3 participants
@suntrix @Reedyuk @nbransby