Replace NanoSQL with Couchbase Lite #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matey97, if it looks good to you and works great on your devices, please try to incorporate it to your branch to check that everything is still working as expected with the high-res recogniser 😉. Thanks |
|
Looks great. I test it in my branch and works as expected. Nice work, as always 😉. |
|
Excellent! Thank you Miguel! Speaking of your branch, I would like to get back to it in November. I think that with some minor changes we can include it as a main functionality of the library. Talk to you soon about it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to its singleton nature, it becomes difficult to synchronise DB access (more concretely, NanoSQL usage) across multiple plugins. This becomes even harder when running code alternatively, due to scatter async calls.
After evaluating multiple alternatives like:
Among the previous list, the last one seems the best maintained one, with more contributors and recent answers to issues. Moreover, it fits well the current usage of the plugin DB and the main author is part of the NativeScript team.
This PR does not induce any code breaking changes. However, any app running in production should cope with having all its recogniser states wiped out. This can lead to some momentary inconsistent detection.