Migrate ns couchbase #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with the migration of this plugin to NS8.
Time to migrate another dependency, the couchbase plugin.
The API remains the same. But it requires a higher min Android SDK, the 22 (Android Lollipop 5.1). What do you think @matey97? Are we ready to ditch Android 4?
I've noticed something strange. The first time that I run the demo and it asks for the permissions, the callback returns automatically right after asking for them saying that no permission has been granted. This happens in the device that I have here with me and also in the emulator. Digging a bit in the problem, I've found that it is because NativeScript calling the application event when the permissions are requested and now when the permission-asking dialog closes. Could you check please if this happens to you too? Thanks