Skip to content

Fix conflicts with plugins using nSQL #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix conflicts with plugins using nSQL #1

merged 1 commit into from
Jul 15, 2020

Conversation

agonper
Copy link
Collaborator

@agonper agonper commented Jul 15, 2020

nSQL fails to run queries when the host app or another plugin is using it too.

To avoid this issue, the database to use should be explicitly specified before executing each nSQL query.

Here's the fix along with some guidelines for plugin's users to avoid having problems with this.

@agonper agonper added the bug Something isn't working label Jul 15, 2020
@agonper agonper requested a review from matey97 July 15, 2020 08:04
Copy link
Contributor

@matey97 matey97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding and good work!

@agonper agonper merged commit 028aff7 into master Jul 15, 2020
@agonper agonper deleted the nsql-fix branch July 20, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants