This repository was archived by the owner on Mar 17, 2025. It is now read-only.
add typed push and set. #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| FirebaseSet Firebase::set(const String& path, double value) { | ||
| return FirebaseSet(host_, auth_, path, jsonEncode(value), &http_); | ||
| } | ||
| FirebaseSet Firebase::set(const String& path, const String& value) { |
There was a problem hiding this comment.
Note: that this will break client that were pushing json encoded string.
If needed, we could error out if the value is decoding to a valid json object / literal to help with the transition.
|
LGTM overall, if possible I would really like to merge #83 first though. |
Closed
proppy
added a commit
to proppy/firebase-arduino
that referenced
this pull request
Apr 27, 2016
|
closing in favor of #98 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #60.