This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Include ArduinoJson directly in our library and parse json. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| These are packages that we depend upon. They may need to be trimmed, all .cpp | |||
There was a problem hiding this comment.
can we use a submodule? or subtree to track this?
There was a problem hiding this comment.
No, we need a subset of the repo, if we include the whole thing arduino will try to compile their tests too. I cannot find a way to submodule or subtree only part of a repo.
Also since they do actual releases it may be nicer to stay synced to actual releases.
There was a problem hiding this comment.
maybe a submodule w/ symlinks in src/?
There was a problem hiding this comment.
I considered that too but from what I gather symlinks in git don't work very well on windows machines.
|
LGTM |
| const String& json() const { | ||
| return json_; | ||
| } | ||
|
|
||
| private: | ||
| String json_; |
There was a problem hiding this comment.
I think we can remove that field :)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.