Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Fix issue #388 ESP8266 fails to reconnect to FIREBASE #388 #401

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

philipnguyen8588
Copy link

I fix this issue
#388

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@philipnguyen8588
Copy link
Author

I signed it!

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@philipnguyen8588
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kotl kotl merged commit 90c0ce4 into FirebaseExtended:master Apr 19, 2019
@PhyoePyae
Copy link

I did and fix this issue. But it is not working in my case.
Please check this :
https://github.community/t/firebase-is-not-reconnected-in-nodemcu/127655?u=phyoepyae

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants