Skip to content

chore(internal): bump httpx dependency #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ dev-dependencies = [
"dirty-equals>=0.6.0",
"importlib-metadata>=6.7.0",
"rich>=13.7.1",
"nest_asyncio==1.6.0"
"nest_asyncio==1.6.0",
]

[tool.rye.scripts]
Expand Down
5 changes: 2 additions & 3 deletions requirements-dev.lock
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ h11==0.14.0
# via httpcore
httpcore==1.0.2
# via httpx
httpx==0.25.2
httpx==0.28.1
# via finch-api
# via respx
idna==3.4
Expand Down Expand Up @@ -76,7 +76,7 @@ python-dateutil==2.8.2
# via time-machine
pytz==2023.3.post1
# via dirty-equals
respx==0.20.2
respx==0.22.0
rich==13.7.1
ruff==0.6.9
setuptools==68.2.2
Expand All @@ -86,7 +86,6 @@ six==1.16.0
sniffio==1.3.0
# via anyio
# via finch-api
# via httpx
time-machine==2.9.0
tomli==2.0.2
# via mypy
Expand Down
3 changes: 1 addition & 2 deletions requirements.lock
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ h11==0.14.0
# via httpcore
httpcore==1.0.2
# via httpx
httpx==0.25.2
httpx==0.28.1
# via finch-api
idna==3.4
# via anyio
Expand All @@ -37,7 +37,6 @@ pydantic-core==2.27.1
sniffio==1.3.0
# via anyio
# via finch-api
# via httpx
typing-extensions==4.12.2
# via anyio
# via finch-api
Expand Down
25 changes: 25 additions & 0 deletions tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import httpx
import pytest
import packaging.version as version
from respx import MockRouter
from pydantic import ValidationError

Expand Down Expand Up @@ -643,6 +644,10 @@ def test_absolute_request_url(self, client: Finch) -> None:
)
assert request.url == "https://myapi.com/foo"

@pytest.mark.skipif(
version.parse(httpx.__version__) >= version.parse("0.28.0"),
reason="Test is only relevant for httpx versions < 0.28.0",
)
def test_transport_option_is_deprecated(self) -> None:
with pytest.warns(
DeprecationWarning,
Expand Down Expand Up @@ -672,6 +677,10 @@ def test_transport_option_mutually_exclusive_with_http_client(self) -> None:
http_client=http_client,
)

@pytest.mark.skipif(
version.parse(httpx.__version__) >= version.parse("0.28.0"),
reason="Test is only relevant for httpx versions < 0.28.0",
)
def test_connection_pool_limits_option_is_deprecated(self) -> None:
with pytest.warns(
DeprecationWarning,
Expand Down Expand Up @@ -709,6 +718,10 @@ def test_connection_pool_limits_option_mutually_exclusive_with_http_client(self)
http_client=http_client,
)

@pytest.mark.skipif(
version.parse(httpx.__version__) >= version.parse("0.28.0"),
reason="Test is only relevant for httpx versions < 0.28.0",
)
def test_proxies_option_is_deprecated(self) -> None:
with pytest.warns(
DeprecationWarning,
Expand Down Expand Up @@ -1527,6 +1540,10 @@ def test_absolute_request_url(self, client: AsyncFinch) -> None:
)
assert request.url == "https://myapi.com/foo"

@pytest.mark.skipif(
version.parse(httpx.__version__) >= version.parse("0.28.0"),
reason="Test is only relevant for httpx versions < 0.28.0",
)
def test_transport_option_is_deprecated(self) -> None:
with pytest.warns(
DeprecationWarning,
Expand Down Expand Up @@ -1556,6 +1573,10 @@ async def test_transport_option_mutually_exclusive_with_http_client(self) -> Non
http_client=http_client,
)

@pytest.mark.skipif(
version.parse(httpx.__version__) >= version.parse("0.28.0"),
reason="Test is only relevant for httpx versions < 0.28.0",
)
def test_connection_pool_limits_option_is_deprecated(self) -> None:
with pytest.warns(
DeprecationWarning,
Expand Down Expand Up @@ -1593,6 +1614,10 @@ async def test_connection_pool_limits_option_mutually_exclusive_with_http_client
http_client=http_client,
)

@pytest.mark.skipif(
version.parse(httpx.__version__) >= version.parse("0.28.0"),
reason="Test is only relevant for httpx versions < 0.28.0",
)
def test_proxies_option_is_deprecated(self) -> None:
with pytest.warns(
DeprecationWarning,
Expand Down