Skip to content

fix(api): update employer_size parameter to employee_size #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(api): update employer_size parameter to employee_size #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/finch/resources/sandbox/connections/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def create(
*,
provider_id: str,
authentication_type: Literal["credential", "api_token", "oauth", "assisted"] | NotGiven = NOT_GIVEN,
employer_size: int | NotGiven = NOT_GIVEN,
employee_size: int | NotGiven = NOT_GIVEN,
products: List[str] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand All @@ -60,7 +60,7 @@ def create(
Create a new connection (new company/provider pair) with a new account

Args:
employer_size: Optional: the size of the employer to be created with this connection. Defaults
employee_size: Optional: the size of the employer to be created with this connection. Defaults
to 20

extra_headers: Send extra headers
Expand All @@ -77,7 +77,7 @@ def create(
{
"provider_id": provider_id,
"authentication_type": authentication_type,
"employer_size": employer_size,
"employee_size": employee_size,
"products": products,
},
connection_create_params.ConnectionCreateParams,
Expand Down Expand Up @@ -107,7 +107,7 @@ async def create(
*,
provider_id: str,
authentication_type: Literal["credential", "api_token", "oauth", "assisted"] | NotGiven = NOT_GIVEN,
employer_size: int | NotGiven = NOT_GIVEN,
employee_size: int | NotGiven = NOT_GIVEN,
products: List[str] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand All @@ -120,7 +120,7 @@ async def create(
Create a new connection (new company/provider pair) with a new account

Args:
employer_size: Optional: the size of the employer to be created with this connection. Defaults
employee_size: Optional: the size of the employer to be created with this connection. Defaults
to 20

extra_headers: Send extra headers
Expand All @@ -137,7 +137,7 @@ async def create(
{
"provider_id": provider_id,
"authentication_type": authentication_type,
"employer_size": employer_size,
"employee_size": employee_size,
"products": products,
},
connection_create_params.ConnectionCreateParams,
Expand Down
2 changes: 1 addition & 1 deletion src/finch/types/sandbox/connection_create_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ConnectionCreateParams(TypedDict, total=False):

authentication_type: Literal["credential", "api_token", "oauth", "assisted"]

employer_size: int
employee_size: int
"""Optional: the size of the employer to be created with this connection.

Defaults to 20
Expand Down
4 changes: 2 additions & 2 deletions tests/api_resources/sandbox/test_connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def test_method_create_with_all_params(self, client: Finch) -> None:
connection = client.sandbox.connections.create(
provider_id="string",
authentication_type="credential",
employer_size=0,
employee_size=0,
products=["string", "string", "string"],
)
assert_matches_type(ConnectionCreateResponse, connection, path=["response"])
Expand Down Expand Up @@ -80,7 +80,7 @@ async def test_method_create_with_all_params(self, async_client: AsyncFinch) ->
connection = await async_client.sandbox.connections.create(
provider_id="string",
authentication_type="credential",
employer_size=0,
employee_size=0,
products=["string", "string", "string"],
)
assert_matches_type(ConnectionCreateResponse, connection, path=["response"])
Expand Down