Skip to content

release: 0.9.4 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
".": "0.9.3"
".": "0.9.4"
}
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## 0.9.4 (2023-12-20)

Full Changelog: [v0.9.3...v0.9.4](https://github.com/Finch-API/finch-api-python/compare/v0.9.3...v0.9.4)

### Chores

* **internal:** minor updates to pagination ([#236](https://github.com/Finch-API/finch-api-python/issues/236)) ([9fb357e](https://github.com/Finch-API/finch-api-python/commit/9fb357e18aa800fd21d62ecb31690abcb65502af))

## 0.9.3 (2023-12-19)

Full Changelog: [v0.9.2...v0.9.3](https://github.com/Finch-API/finch-api-python/compare/v0.9.2...v0.9.3)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "finch-api"
version = "0.9.3"
version = "0.9.4"
description = "The official Python library for the Finch API"
readme = "README.md"
license = "Apache-2.0"
Expand Down
2 changes: 1 addition & 1 deletion src/finch/_version.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# File generated from our OpenAPI spec by Stainless.

__title__ = "finch"
__version__ = "0.9.3" # x-release-please-version
__version__ = "0.9.4" # x-release-please-version
100 changes: 30 additions & 70 deletions src/finch/pagination.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ class SyncSinglePage(BaseSyncPage[ModelT], BasePage[ModelT], Generic[ModelT]):

@override
def _get_page_items(self) -> List[ModelT]:
items = self.items
if not items:
return []
return items
return self.items

@override
def next_page_info(self) -> None:
Expand All @@ -58,10 +55,7 @@ class AsyncSinglePage(BaseAsyncPage[ModelT], BasePage[ModelT], Generic[ModelT]):

@override
def _get_page_items(self) -> List[ModelT]:
items = self.items
if not items:
return []
return items
return self.items

@override
def next_page_info(self) -> None:
Expand All @@ -86,10 +80,7 @@ class SyncResponsesPage(BaseSyncPage[ModelT], BasePage[ModelT], Generic[ModelT])

@override
def _get_page_items(self) -> List[ModelT]:
responses = self.responses
if not responses:
return []
return responses
return self.responses

@override
def next_page_info(self) -> None:
Expand All @@ -105,10 +96,7 @@ class AsyncResponsesPage(BaseAsyncPage[ModelT], BasePage[ModelT], Generic[ModelT

@override
def _get_page_items(self) -> List[ModelT]:
responses = self.responses
if not responses:
return []
return responses
return self.responses

@override
def next_page_info(self) -> None:
Expand All @@ -125,29 +113,22 @@ class SyncIndividualsPage(BaseSyncPage[ModelT], BasePage[ModelT], Generic[ModelT

@override
def _get_page_items(self) -> List[ModelT]:
individuals = self.individuals
if not individuals:
return []
return individuals
return self.individuals

@override
def next_page_info(self) -> Optional[PageInfo]:
offset = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
offset = self.paging.offset
offset = self.paging.offset
if offset is None:
return None

length = len(self._get_page_items())
length = len(self.individuals)
current_count = offset + length

count = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
count = self.paging.count
if count is None:
total_count = self.paging.count
if total_count is None:
return None

if current_count < count:
if current_count < total_count:
return PageInfo(params={"offset": current_count})

return None
Expand All @@ -159,97 +140,76 @@ class AsyncIndividualsPage(BaseAsyncPage[ModelT], BasePage[ModelT], Generic[Mode

@override
def _get_page_items(self) -> List[ModelT]:
individuals = self.individuals
if not individuals:
return []
return individuals
return self.individuals

@override
def next_page_info(self) -> Optional[PageInfo]:
offset = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
offset = self.paging.offset
offset = self.paging.offset
if offset is None:
return None

length = len(self._get_page_items())
length = len(self.individuals)
current_count = offset + length

count = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
count = self.paging.count
if count is None:
total_count = self.paging.count
if total_count is None:
return None

if current_count < count:
if current_count < total_count:
return PageInfo(params={"offset": current_count})

return None


class SyncPage(BaseSyncPage[ModelT], BasePage[ModelT], Generic[ModelT]):
data: List[ModelT]
paging: Paging
data: List[ModelT]

@override
def _get_page_items(self) -> List[ModelT]:
data = self.data
if not data:
return []
return data
return self.data

@override
def next_page_info(self) -> Optional[PageInfo]:
offset = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
offset = self.paging.offset
offset = self.paging.offset
if offset is None:
return None

length = len(self._get_page_items())
length = len(self.data)
current_count = offset + length

count = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
count = self.paging.count
if count is None:
total_count = self.paging.count
if total_count is None:
return None

if current_count < count:
if current_count < total_count:
return PageInfo(params={"offset": current_count})

return None


class AsyncPage(BaseAsyncPage[ModelT], BasePage[ModelT], Generic[ModelT]):
data: List[ModelT]
paging: Paging
data: List[ModelT]

@override
def _get_page_items(self) -> List[ModelT]:
data = self.data
if not data:
return []
return data
return self.data

@override
def next_page_info(self) -> Optional[PageInfo]:
offset = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
offset = self.paging.offset
offset = self.paging.offset
if offset is None:
return None

length = len(self._get_page_items())
length = len(self.data)
current_count = offset + length

count = None
if self.paging is not None: # pyright: ignore[reportUnnecessaryComparison]
count = self.paging.count
if count is None:
total_count = self.paging.count
if total_count is None:
return None

if current_count < count:
if current_count < total_count:
return PageInfo(params={"offset": current_count})

return None