release: 0.1.4 #111
Merged
release: 0.1.4 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
6e45d8f to
bd07c7f
Compare
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
4aadcd9 to
b90cd33
Compare
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
28c103c to
a05398c
Compare
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
src/finch/_client.py
Outdated
Comment on lines
243
to
246
| If | ||
| Finch’s unified API doesn’t have a data model that cleanly fits your needs, then | ||
| Forward allows you to push or pull data models directly against an integration’s | ||
| API. |
There was a problem hiding this comment.
Actually I'd just remove these lines.
There was a problem hiding this comment.
We removed these from now, but you'll need to make the changes you want for documentation like this in your OpenAPI spec before the next update for them to persist. Is that OK?
sshariff01
reviewed
Oct 3, 2023
src/finch/_client.py
Outdated
| headers: Optional[object] | NotGiven = NOT_GIVEN, | ||
| params: Optional[object] | NotGiven = NOT_GIVEN, | ||
| # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs. | ||
| # The extra values given here take precedence over values defined on the client or passed to this method. |
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
51c0f6e to
ef97220
Compare
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
|
|
||
| Args: | ||
| method: The HTTP method for the forwarded request. Valid values include: `GET` , `POST` | ||
| , `PUT` , `DELETE` , and `PATCH`. |
There was a problem hiding this comment.
Nitpick - Can we bring this comma up to be on the previous line?
There was a problem hiding this comment.
Ah, this was because your OpenAPI spec has spaces after the the backticks; you'll want to fix that up soon.
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
sshariff01
reviewed
Oct 3, 2023
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
ce684fd to
7b68074
Compare
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
386a7cd to
03a9546
Compare
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
ee7ef49 to
0b9561d
Compare
sshariff01
approved these changes
Oct 3, 2023
stainless-bot
force-pushed
the
release-please--branches--main--changes--next
branch
from
19a3fbc to
0b9561d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated Release PR
0.1.4 (2023-10-04)
Full Changelog: v0.1.3...v0.1.4
Features
/forwardendpoint and other updates (#116) (ef97220)Chores
This Pull Request has been generated automatically as part of Stainless's release process.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request (see details).
More technical details can be found at stainless-api/release-please.