Skip to content

feat: Use double quotes in vue file snippets #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 3, 2023
Merged

feat: Use double quotes in vue file snippets #50

merged 8 commits into from
Jul 3, 2023

Conversation

HenBK
Copy link
Contributor

@HenBK HenBK commented Jul 3, 2023 •
edited
Loading

Updated snippets to use double quotes instead of single quotes in the <script> tag to keep consistency across the template as discussed in this issue :)

I was able to successfully test the changes locally, everything seems to work as expected, here's a small sample test video I recorded:

test of vbase snippet showing code generated with double quotes on all html property values

@HenBK HenBK mentioned this pull request Jul 3, 2023
Closed
@HenBK HenBK changed the title Update snippets to generate the script tag lang property using double quotes instead of single quotes Update snippets to generate the script tag "lang" property using double quotes instead of single quotes Jul 3, 2023
ExEr7um
ExEr7um reviewed Jul 3, 2023
View reviewed changes
Copy link
Owner

@ExEr7um ExEr7um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump version and create changelog, it will be done automatically when I release package. Can you please remove it?

@ExEr7um ExEr7um linked an issue Jul 3, 2023 that may be closed by this pull request
Single quotes vs Double quotes on lang property of script tag #49
Closed
@ExEr7um ExEr7um added the Feature New feature or request label Jul 3, 2023
@HenBK
Copy link
Contributor Author

HenBK commented Jul 3, 2023

No need to bump version and create changelog, it will be done automatically when I release package. Can you please remove it?

done!

@ExEr7um ExEr7um changed the title Update snippets to generate the script tag "lang" property using double quotes instead of single quotes feat: Use double quotes in vue file snippets Jul 3, 2023
@ExEr7um ExEr7um merged commit 0bd9f14 into ExEr7um:main Jul 3, 2023
@ExEr7um
Copy link
Owner

ExEr7um commented Jul 3, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExEr7um ExEr7um ExEr7um approved these changes

Assignees
No one assigned
Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single quotes vs Double quotes on lang property of script tag
2 participants
@HenBK @ExEr7um