Skip to content

Single quotes vs Double quotes on lang property of script tag #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HenBK opened this issue Jul 2, 2023 · 2 comments · Fixed by #50
Closed

Single quotes vs Double quotes on lang property of script tag #49

HenBK opened this issue Jul 2, 2023 · 2 comments · Fixed by #50
Labels
Feature New feature or request Good First Issue Good issue for new contributors
Milestone

Comments

@HenBK
Copy link
Contributor

HenBK commented Jul 2, 2023

Hi there, I wanted to thank you for making this extension, it was very annoying to manually move the script tag to the top of the file each time I generated a new single file component using vbase, so thanks a lot.

I opened this issue because I wanted to suggest the use of double quotes for the value of the lang property in the <script> tag, so it goes from <script setup lang='ts'> to <script setup lang="ts">

Even though this is a small change and doesn't make much of a difference in terms of functionality I do think it would be beneficial since it would help to keep consistency considering that the extension currently generates the <style> tag in this way <style lang="scss"> and most html property values tend to be set with double quotes by other code generation tools

Best regards!

@ExEr7um ExEr7um added Feature New feature or request Good First Issue Good issue for new contributors labels Jul 2, 2023
@ExEr7um ExEr7um added this to the v0.5.0 milestone Jul 2, 2023
@ExEr7um
Copy link
Owner

ExEr7um commented Jul 2, 2023

Thanks for the issue. Yes, I think we should make it consistent with double quotes. PRs are welcome!

@HenBK
Copy link
Contributor Author

HenBK commented Jul 3, 2023

Opened the pull request :)

I'm not entirely sure if I updated the CHANGELOG correctly or if I pumped the version the right way so let me know if there is any changes you would like me to make, happy to help!

@ExEr7um ExEr7um linked a pull request Jul 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Good First Issue Good issue for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants