wrong engine being used

[maapteh]

fixes #77

error @endemolshinegroup/[email protected]: The engine "yarn" is incompatible with this module. Expected version ">=1.3.0".
error Found incompatible module

[hassankhan]

Fixed in 09983de

[maapteh]

No you didnt fix it
https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md

[maapteh]

@hassankhan pls check your changes, they are wrong

[hassankhan]

Hi @maapteh,

Thanks for the update. In #77, you said the issue was that v1.3.0 does not exist. I looked through the available versions from npmjs.com and picked the closest version that did exist.

Do you by any chance have a test repo I can use to see the issue for myself?

[maapteh]

I also mentioned that maybe you meant NPM and not YARN

the issue happens when you use your PUBLISHED npm library with yarn then it reads its package json and has the engine set to a yarn version which is not existing by facebook at all :) the engine is used when installing with yarn for its minimal requirements. So you want node version at least 10. Thats fine. But look what you write at yarn, thats not npm its yarn and yarn is now at 1.22 and your module for sure dont need this latest. It will work with any :)

[maapteh]

Just remove that line, what i did in my PR which you then not took over. Good luck!

[hassankhan]

Ahhh right I see now, thanks for the explanation, I hadn't even realized that it could be an issue in that way 😅 will fix up shortly 👍

[hassankhan]

Fixed in 26e9aec