Skip to content

ci(sync-labels): Create sync-labels.yml workflow #7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Sep 7, 2022

What does this PR do?

Improve repo

For resources

Description

  • Using a wide used crazy-max/ghaction-github-labeler action
  • Save current repository labels in a file
  • Monitor this file to auto import labels to the repo.
  • Having a manual way to run it with granularity over input parameters (test and deletions)
  • If a PR is open test CRUD, if merged... do modifications but without deleting any label (the least destructive action)

Why this?

Allows to collaborators add manage the repo labels having the last desision whom have write permissions.

E.g. add the labels of new locale (see #7024 (comment))

Dry-run over this repository: https://github.com/EbookFoundation/free-programming-books/runs/8230716302?check_suite_focus=true#step:3:218

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added 👀 Needs Review Is this really a good resource? Reviews requested. 🤖 automation Automated tasks done by workflows or bots labels Sep 7, 2022
@davorpa davorpa self-assigned this Sep 7, 2022
@davorpa davorpa added the New Feature New feature / enhancement / translation... label Sep 7, 2022
@davorpa davorpa marked this pull request as ready for review September 7, 2022 14:46
@eshellman
Copy link
Collaborator

I don't understand the problem this is trying to address.

@davorpa
Copy link
Member Author

davorpa commented Sep 7, 2022

I don't understand the problem this is trying to address.

Sorry if I can't explain it better in english

See Why this? section. One more...

  • Have same repo labels in forks than in upstream repo

@eshellman
Copy link
Collaborator

this appears to have created 4 new checks. This will tend to obscure the checks we want people to pay attention to. It's a feature that adds complexity and maintenance burden for the benefit of only a small number of maintainers. I think a better course would be to reduce the number of labels to something that can more easily managed by hand. The fact that you feel a need for automation to manage the labels suggests that there are too many labels!!

@eshellman eshellman closed this Sep 7, 2022
@davorpa
Copy link
Member Author

davorpa commented Sep 8, 2022

I understand 👍 . Let's keep it simple!

It was only an idea to start to triage resources using labels.

The reason I added the locale labels in the past was for classifying resources, and if someone want to susbcribe to this files changes, e.g. a mantainer in charge of review PRs of this country/language, they have a way to use filters. Obviously, the second part is not developed yet (extract locale slug from files and do the label triage #7024 (comment)).

But maybe #7024 (comment) would be a better aproach to group resources by locale and mantain files low sizing. A big breaking change for us that needs coordination!!

this appears to have created 4 new checks...

Acording to on events these checks only appears if any of both files (labels.yml, sync-labels.yml) change!

I have this other workflow if only one job (or whatever you call "check") and 4 steps if is needed in a future.

davorpa/testing-github-actions@4722aba#diff-a877ed9f27d115d95934fd904f2475dcec6ce4125da686dd5b3c75a696fff1c6R4-R10

Some workflow runs at:

Feel free to take a look.

Said that.... next workflow: auto-conflicts 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automation Automated tasks done by workflows or bots 👀 Needs Review Is this really a good resource? Reviews requested. New Feature New feature / enhancement / translation...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants