Skip to content

fix(books): free-programming-books-ko broken link #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

LuigiImVector
Copy link
Member

@LuigiImVector LuigiImVector commented Jul 20, 2022

What does this PR do?

Improve repo

For resources

Description

Solved a problem of #6942.
This book is similar to https://thebook.io/080277/, the author is the same (006718 & 080277) but I still think they are two separate books

For book lists, is it a book? For course lists, is it a course? etc.

It's a book

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@LuigiImVector LuigiImVector self-assigned this Jul 20, 2022
@LuigiImVector LuigiImVector added the 🗣️ locale:ko Resources addressing "Korean / 한국어 [韓國語]" language label Jul 20, 2022
@davorpa
Copy link
Member

davorpa commented Jul 20, 2022

Without an opinion of anybody mother language, I can argue that is better for me use archived resource than replacement

@davorpa davorpa added question Needs clarification by involved users / reviewers help wanted Needs help solving a blocked / stucked item labels Jul 20, 2022
@LuigiImVector
Copy link
Member Author

Without an opinion of anybody mother language, I can argue that is better for me use archived resource than replacement

I agree, maybe @rumaniel can help us, I saw that he contributed to the repository some time ago

@eshellman
Copy link
Collaborator

LGTM

@eshellman eshellman merged commit 035e71f into EbookFoundation:main Jul 21, 2022
@davorpa davorpa added urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. and removed question Needs clarification by involved users / reviewers help wanted Needs help solving a blocked / stucked item labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗣️ locale:ko Resources addressing "Korean / 한국어 [韓國語]" language urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants