-
-
Notifications
You must be signed in to change notification settings - Fork 63.2k
config: update .editorconfig
parameters according to current format of files
#6696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: update .editorconfig
parameters according to current format of files
#6696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you use ;
for the rule comments and #
for the file description? And why did you include the python, bat, powershell files if they are not used?
According documentation comments can be addressed by So to differentiate, I've preferred to use
Sorry, I have some scripts in my local environment testing things with nodejs and remark. Let's decide if revert fd9a837, 5516f58, 20bac81, 4b2c37b commits is needed. Its parametrization is taken from known examples provided in: https://github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig Moreover... I update the link pointing to this repo in that wiki 😜 |
I just use the same EditorConfig file in all my projects, regardless of the contents of the repository. (This One) The above is an opinion, and nothing more. However, I think most if not all the comments should be entirely removed. (EditorConfig is very self-explanatory as it is.)
And the comments aren't necessarily accurate either. "Compress" compared to what? In other words, the EditorConfig describes how the code should look to editors. |
I do also wonder where all the file extensions came from, for example Markdown.
On Wikipedia:
This is also another case where the comment seems a bit redundant. ^-^' Edit: Just realized the file extensions were linked, fair enough. Does still seem cluttered to have them all through in the repository. Just |
Thanks for the starter template. Adopted a bit. Comments are in part for my future self (I have a fish memory sometimes) Better now after 520d0e9 or completely remove not used? |
Comments are better now even if i think you can remove the unused ones |
What more I need to go ahead with the PR? |
I think the only problems are the "excess" of information it contains: comments and (not yet) used extensions. Comments can be left as they are in my opinion, for the extensions (ps1, js, ts...) I find that they are currently useless but could be used in the future, if no one opposes PR can be merged. |
- simplify properties already defined in global section - remove not used future patterns
I clean it a bit more. |
LGTM |
What does this PR do?
Improve repo
For resources
Description
Update
.editorconfig
parameters according to values provided by @SethFalco in #5564 (commit e9f7dff) and extend it.yaml
oryml
filesjson
&jsonc
(commented) filesMoreabout editorconfig syntax at: https://editorconfig.org/
Checklist:
Follow-up